Update examples to use SpriteCircle's new center_* keyword arguments #2767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushfoo
changed the title
pushfoo
force-pushed
the
clean_up_example_sprite_circle_kwargs
branch
from
5b4b19d to
5109fb2
Compare
|
CI failure's due to unpinned |
|
Fixed the mypy issue in #2768. |
* Use center_x and center_y arguments for sprites * Account for grid cells that are short and wide via min
* Use center_x and center_y arguments * Use shared kwargs to shorten code
pushfoo
force-pushed
the
clean_up_example_sprite_circle_kwargs
branch
from
5109fb2 to
ee5a683
Compare
|
It's been idle for 3 weeks with no objections. We can polish further at a later time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2766:
SpriteCirclekeyword arguments in examples (center_x,center_y)ruff formaton altered files